fgerlits commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r716612699
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -105,6 +105,10 @@ class StringUtils {
return s;
}
+ static std::string_view trim(const std::string_view& sv);
+
+ static std::string_view trim(const char* str);
Review comment:
These two could be replaced with a single `trim(std::string_view
input)`. Also, by looking around the internets, I got the impression that
passing `string_view` by value is generally preferable to passing it by (const)
reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
