szaszm commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r740796328
##########
File path: cmake/BuildTests.cmake
##########
@@ -111,6 +111,11 @@ FOREACH(testfile ${UNIT_TESTS})
target_link_libraries(${testfilename} ${CATCH_MAIN_LIB})
MATH(EXPR UNIT_TEST_COUNT "${UNIT_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY
${TEST_DIR})
+ if (WIN32)
+ target_compile_options(${testfilename} PRIVATE "/W")
+ else()
+ target_compile_options(${testfilename} PRIVATE "-w")
+ endif()
Review comment:
Try using pragmas to disable this specific warning. Not sure if they
need to be around the macro definition or the substitution.
gcc: https://stackoverflow.com/a/3394268
msvc: https://stackoverflow.com/a/4292391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
