martinzink commented on a change in pull request #1188: URL: https://github.com/apache/nifi-minifi-cpp/pull/1188#discussion_r735430824
########## File path: extensions/standard-processors/processors/DefragmentText.h ########## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <regex> +#include <memory> +#include <string> +#include <set> + +#include "core/Processor.h" +#include "core/FlowFileStore.h" +#include "core/logging/Logger.h" +#include "core/logging/LoggerConfiguration.h" +#include "utils/Enum.h" +#include "serialization/PayloadSerializer.h" + +namespace org::apache::nifi::minifi::processors { + +class DefragmentText : public core::Processor { + public: + explicit DefragmentText(const std::string& name, const utils::Identifier& uuid = {}) + : Processor(name, uuid) { + } + EXTENSIONAPI static const core::Relationship Self; + EXTENSIONAPI static const core::Relationship Success; + EXTENSIONAPI static const core::Relationship Failure; + + EXTENSIONAPI static const core::Property Pattern; + EXTENSIONAPI static const core::Property PatternLoc; + EXTENSIONAPI static const core::Property MaxBufferAge; + EXTENSIONAPI static const core::Property MaxBufferSize; + + void initialize() override; + void onSchedule(core::ProcessContext* context, core::ProcessSessionFactory* sessionFactory) override; + void onTrigger(core::ProcessContext* context, core::ProcessSession* session) override; + void restore(const std::shared_ptr<core::FlowFile>& flowFile) override; + std::set<std::shared_ptr<core::Connectable>> getOutGoingConnections(const std::string &relationship) const override; + + SMART_ENUM(PatternLocation, + (END_OF_MESSAGE, "End of Message"), + (START_OF_MESSAGE, "Start of Message") + ) + + protected: + class Buffer { + public: + bool isCompatible(const std::shared_ptr<core::FlowFile>& flow_file_to_append) const; + void append(core::ProcessSession* session, const std::shared_ptr<core::FlowFile>& flow_file_to_append); + bool maxSizeReached() const; + bool maxAgeReached() const; + void setMaxAge(uint64_t max_age); + void setMaxSize(size_t max_size); + void flushAndReplace(core::ProcessSession* session, const core::Relationship& relationship, + const std::shared_ptr<core::FlowFile>& new_buffered_flow_file); + + bool empty() const { return buffered_flow_file_ == nullptr; } + + private: + void store(core::ProcessSession* session, const std::shared_ptr<core::FlowFile>& new_buffered_flow_file); + + std::shared_ptr<core::FlowFile> buffered_flow_file_; + std::chrono::time_point<std::chrono::system_clock> creation_time_; + std::optional<std::chrono::milliseconds> max_age_; + std::optional<size_t> max_size_; + }; + + std::mutex defrag_mutex_; Review comment: rebased removed the mutex and added the the isSingleThreaded in https://github.com/apache/nifi-minifi-cpp/pull/1188/commits/b01973d54c61708b44422c7c24db5c611a7d89be -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
