Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/45#discussion_r85601256
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/serialization/SchemaLoader.java
---
@@ -78,6 +80,27 @@ public static ConfigSchema
loadConfigSchemaFromYaml(Map<String, Object> yamlAsMa
public static ConvertableSchema<ConfigSchema>
loadConvertableSchemaFromYaml(Map<String, Object> yamlAsMap) throws
SchemaLoaderException {
String version =
String.valueOf(yamlAsMap.get(ConfigSchema.VERSION));
+ if (StringUtil.isNullOrEmpty(version) || String.valueOf((Object)
null).equals(version)) {
--- End diff --
@JPercivall sorry, I thought you were wanting behavior like that in regards
to [your comment
above.](https://github.com/apache/nifi-minifi/pull/45#discussion_r85137468)
I must've misread the comment, now it's looking more like it may have been
automatically addressed by the other validation change which clears the errors
before converting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
