Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/45#discussion_r85603814
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/serialization/SchemaLoader.java
---
@@ -78,6 +80,27 @@ public static ConfigSchema
loadConfigSchemaFromYaml(Map<String, Object> yamlAsMa
public static ConvertableSchema<ConfigSchema>
loadConvertableSchemaFromYaml(Map<String, Object> yamlAsMap) throws
SchemaLoaderException {
String version =
String.valueOf(yamlAsMap.get(ConfigSchema.VERSION));
+ if (StringUtil.isNullOrEmpty(version) || String.valueOf((Object)
null).equals(version)) {
--- End diff --
Sorry my prior comment was confusing and I think it was a little off-base
anyway. Lol feel free to let me know when I am (confusing or off-base).
That said, we need to be careful what we include in this SchemaLoader
because it is not only used by the toolkit but also the agent itself. We don't
want the agent assuming the version of schema.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
