exceptionfactory commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1022273920
The `getDriver()` method appears to be exactly the same as the `DBCPConnectionPool`, so perhaps I am missing how duplicating it changes the runtime behavior. Although there may be some marginal utility in having an explicit controller service, I am not in favor of the current approach without more significant code reduction of duplication. If that requires some refactoring of `DBCPConnectionPool` to enable clean extension, that seems better than duplicating property descriptors and configuration methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
