tpalfy commented on pull request #5692: URL: https://github.com/apache/nifi/pull/5692#issuecomment-1022303168
Regarding the ```getDriver()``` can you please help me understand which part needs further explanation in this: > The reason why we can't rely on the DBCPConnectionPool.getDriver() is that the subsequent Class.forName() call uses the classloader of the caller class. Which would be the nifi-dbcp-service NAR classloader which doesn't see the snowflake driver as that is included in the nifi-snowflake-services NAR. I'm really not sure how I could explain better. As for the concerns about code duplication I think "more significant code reduction of duplication" lacks sufficient specificity. I reduced code duplication already significantly and addressed the remaining ones in great detail in my previous comments. With that I'll consider this argument void for vagueness. I feel like we are just running around in circles with little to no benefit. I'll leave the implementation the way as it is now. I'll consider subsequent suggestions if they are sufficiently specific and the reviewer can confirm their validity by trying them out in a running environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
