[ https://issues.apache.org/jira/browse/MINIFICPP-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486880#comment-17486880 ]
Gábor Gyimesi commented on MINIFICPP-1741: ------------------------------------------ Note: we cannot be sure that the image used for testing is the same as we use in the build session. So even if we specify the feature we want to test the image could be an earlier build or an image pulled from a registry which may or may not contain those features. Or we do not really want to build a new image because we only changed the test framework so we can just run the docker-verify command with no cmake flags specified. > Docker-based integration tests should only test features which are available > ---------------------------------------------------------------------------- > > Key: MINIFICPP-1741 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1741 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement > Reporter: Ferenc Gerlits > Priority: Minor > Labels: MiNiFi-CPP-Hygiene > > To run the docker-based integration tests, you > # run {{cmake}} with some set of flags to enable or disable certain features; > # run {{make docker}} to create the minifi image; > # run {{make docker-verify}} to run the tests. > The problem is that the image created in (2) will only contain the features > selected in (1), but (3) will run all tests, even those which require a > feature not included in the image – these tests will fail. > We should find a way to only run tests for features enabled in the {{cmake}} > step, as it is done in the case of unit tests. -- This message was sent by Atlassian Jira (v8.20.1#820001)