[
https://issues.apache.org/jira/browse/MINIFICPP-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488694#comment-17488694
]
Ádám Markovics commented on MINIFICPP-1741:
-------------------------------------------
# Running all docker tests could be controlled from a CMake cache variable,
that would be passed to DockerVerify.sh
# Running only the enabled features could be controlled from multiple CMake
cache variables, that would be passed to DockerVerify.sh, similarly as to
DockerBuild.sh
# Running only one test explicitly asked by the user could be controlled from
CLI (as it is a development use case), the user directly calling DockerVerify.sh
Also MINIFI_VERSION could be read from CMake cache (or a separate file
dedicated to version) to eliminate that command line argument for
DockerVerify.sh script, leaving only one for the tests.
> Docker-based integration tests should only test features which are available
> ----------------------------------------------------------------------------
>
> Key: MINIFICPP-1741
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1741
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Ferenc Gerlits
> Priority: Minor
> Labels: MiNiFi-CPP-Hygiene
>
> To run the docker-based integration tests, you
> # run {{cmake}} with some set of flags to enable or disable certain features;
> # run {{make docker}} to create the minifi image;
> # run {{make docker-verify}} to run the tests.
> The problem is that the image created in (2) will only contain the features
> selected in (1), but (3) will run all tests, even those which require a
> feature not included in the image – these tests will fail.
> We should find a way to only run tests for features enabled in the {{cmake}}
> step, as it is done in the case of unit tests.
> We should have 3 options of running docker tests:
> # Run all of them
> # Run only the ones whose flags are enabled in CMake (this should be the
> default)
> # Run only one explicity asked by the user (useful during development)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
