exceptionfactory commented on a change in pull request #5909:
URL: https://github.com/apache/nifi/pull/5909#discussion_r836519202
##########
File path: pom.xml
##########
@@ -551,6 +551,12 @@
<scope>import</scope>
<type>pom</type>
</dependency>
+
+ <dependency>
+ <groupId>com.maxmind.geoip2</groupId>
+ <artifactId>geoip2</artifactId>
+ <version>2.16.1</version>
+ </dependency>
Review comment:
Rather than promoting this version to the root Maven configuration, it
seems better to add it in the `pom.xml` for `nifi-nar-bundles`. That should
cover all current dependencies, and that Maven configuration already has a
dependency management section. If this dependency extends to other components,
such as MiNiFi or Registry, then we could consider moving it to the root Maven
configuration at that time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
