exceptionfactory commented on a change in pull request #5909:
URL: https://github.com/apache/nifi/pull/5909#discussion_r836760762
##########
File path: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/pom.xml
##########
@@ -90,6 +89,11 @@
<version>1.16.0-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.jr</groupId>
+ <artifactId>jackson-jr-objects</artifactId>
+ <version>2.13.1</version>
Review comment:
Can this use `${jackson.version}`?
##########
File path: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/pom.xml
##########
@@ -90,6 +89,11 @@
<version>1.16.0-SNAPSHOT</version>
<scope>compile</scope>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.jr</groupId>
+ <artifactId>jackson-jr-objects</artifactId>
Review comment:
This dependency appears to be used only in test classes, is that
correct? If so, the `scope` should be set to `test`.
##########
File path:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIPRecord.java
##########
@@ -102,14 +102,6 @@
.addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.build();
- public static final PropertyDescriptor GEO_ACCURACY = new
PropertyDescriptor.Builder()
Review comment:
Will removing this property cause existing flow deployments to be
invalid when upgrading? If the property simply becomes an unused dynamic
property, that seems fine, but if it makes the processor invalid, then it seems
necessary to keep this property and just update the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
