[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1360: MINIFICPP-1853 Enable multiple metrics from the same processor type

[GitBox]

lordgamez commented on code in PR #1360:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1360#discussion_r940154581


##########
extensions/standard-processors/processors/GetFile.h:
##########
@@ -62,23 +62,27 @@ class GetFileMetrics : public state::response::ResponseNode 
{
   std::vector<state::response::SerializedResponseNode> serialize() override {
     std::vector<state::response::SerializedResponseNode> resp;
 
+    state::response::SerializedResponseNode root_node;
+    root_node.name = source_component_.getName();

Review Comment:
   I would prefer using names to make the C2 JSON more readable and the 
processors more recognizable, but I agree that the UUID would be currently more 
robust as it avoids duplicates. Do you think it should be allowed for multiple 
processors to share the same name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org