lordgamez commented on code in PR #1360:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1360#discussion_r943169629
##########
libminifi/src/core/state/nodes/ResponseNodeLoader.cpp:
##########
@@ -153,32 +153,34 @@ void ResponseNodeLoader::initializeFlowMonitor(const
std::shared_ptr<ResponseNod
}
}
-std::shared_ptr<ResponseNode> ResponseNodeLoader::loadResponseNode(const
std::string& clazz, core::ProcessGroup* root) {
- auto response_node = getResponseNode(clazz);
- if (!response_node) {
+std::vector<std::shared_ptr<ResponseNode>>
ResponseNodeLoader::loadResponseNodes(const std::string& clazz,
core::ProcessGroup* root) {
+ auto response_nodes = getResponseNodes(clazz);
+ if (response_nodes.empty()) {
logger_->log_error("No metric defined for %s", clazz);
- return nullptr;
+ return {};
}
- initializeRepositoryMetrics(response_node);
- initializeQueueMetrics(response_node, root);
- initializeAgentIdentifier(response_node);
- initializeAgentMonitor(response_node);
- initializeAgentNode(response_node);
- initializeConfigurationChecksums(response_node);
- initializeFlowMonitor(response_node, root);
- return response_node;
+ for (const auto& response_node : response_nodes) {
+ initializeRepositoryMetrics(response_node);
+ initializeQueueMetrics(response_node, root);
+ initializeAgentIdentifier(response_node);
+ initializeAgentMonitor(response_node);
+ initializeAgentNode(response_node);
+ initializeConfigurationChecksums(response_node);
+ initializeFlowMonitor(response_node, root);
+ }
+ return response_nodes;
}
-std::shared_ptr<state::response::ResponseNode>
ResponseNodeLoader::getComponentMetricsNode(const std::string& metrics_class)
const {
+std::vector<std::shared_ptr<ResponseNode>>
ResponseNodeLoader::getComponentMetricsNodes(const std::string& metrics_class)
const {
if (!metrics_class.empty()) {
std::lock_guard<std::mutex> lock(component_metrics_mutex_);
- const auto citer = component_metrics_.find(metrics_class);
- if (citer != component_metrics_.end()) {
- return citer->second;
+ auto it = component_metrics_.find(metrics_class);
Review Comment:
It may have needed to be changed in some point of the development, but it is
unneeded now, changed in bf46f4dbb1245cd6b1ba4108f08cfaf56694d0ae
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
