martinzink commented on code in PR #1383:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1383#discussion_r947878733
##########
libminifi/include/utils/BaseHTTPClient.h:
##########
@@ -51,38 +39,30 @@ struct HTTPProxy {
int port = 0;
};
-struct HTTPUploadCallback {
- HTTPUploadCallback() {
- stop = false;
- ptr = nullptr;
- pos = 0;
- }
- std::mutex mutex;
- std::atomic<bool> stop;
- ByteInputCallback *ptr;
- size_t pos;
+class HTTPUploadCallback : public ByteInputCallback {
+ public:
+ template<typename... Args>
+ explicit HTTPUploadCallback(Args&& ... args) :
ByteInputCallback(std::forward<Args>(args)...) {}
size_t getPos() {
- std::lock_guard<std::mutex> lock(mutex);
return pos;
}
Review Comment:
makes sense, removed them in
https://github.com/apache/nifi-minifi-cpp/pull/1383/commits/b80c1c4c6adee5dba02fe5bd355f8732769edf99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
