martinzink commented on code in PR #1383:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1383#discussion_r952697746
##########
extensions/http-curl/client/HTTPClient.h:
##########
@@ -51,17 +53,28 @@
#include "core/logging/Logger.h"
#include "core/logging/LoggerConfiguration.h"
-namespace org::apache::nifi::minifi::utils {
+namespace org::apache::nifi::minifi::extensions::curl {
-/**
- * Purpose and Justification: Pull the basics for an HTTPClient into a self
contained class. Simply provide
- * the URL and an SSLContextService ( can be null).
- *
- * Since several portions of the code have been relying on curl, we can
encapsulate most CURL HTTP
- * operations here without maintaining it everywhere. Further, this will help
with testing as we
- * only need to to test our usage of CURL once
- */
-class HTTPClient : public BaseHTTPClient, public core::Connectable {
+struct KeepAliveProbeData {
+ std::chrono::seconds keep_alive_delay;
+ std::chrono::seconds keep_alive_interval;
+};
+
+struct HTTPResponseData {
+ std::vector<char> response_body;
+ utils::HTTPHeaderResponse header_response;
+ char* response_content_type;
+ int64_t response_code;
Review Comment:
not at all, fixed in
https://github.com/apache/nifi-minifi-cpp/pull/1383/commits/3edf5fcfd603463b67bd6c072fa0128bbb861787#diff-475912c726caf957fa46ce1b55d3e845e89aa19b4c7caf2cd4a0ae1f860cbdd5R56-R57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
