[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

[GitBox]

martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044561423


##########
extensions/script/tests/TestExecuteScriptProcessorWithLuaScript.cpp:
##########
@@ -421,8 +412,10 @@ TEST_CASE("Lua: Test Module Directory property", 
"[executescriptLuaModuleDirecto
                                           true);
 
   plan->setProperty(executeScript, 
minifi::processors::ExecuteScript::ScriptEngine.getName(), "lua");
-  plan->setProperty(executeScript, 
minifi::processors::ExecuteScript::ScriptFile.getName(), 
getScriptFullPath("foo_bar_processor.lua"));
-  plan->setProperty(executeScript, 
minifi::processors::ExecuteScript::ModuleDirectory.getName(), 
getScriptFullPath("foo_modules/foo.lua") + "," + 
getScriptFullPath("bar_modules"));
+  plan->setProperty(executeScript, 
minifi::processors::ExecuteScript::ScriptFile.getName(), script_files_directory 
/ "foo_bar_processor.lua");
+  plan->setProperty(executeScript,
+                    
minifi::processors::ExecuteScript::ModuleDirectory.getName(),
+                    (script_files_directory / "foo_modules/foo.lua").string() 
+ "," + (script_files_directory / "bar_modules").string());

Review Comment:
   Looks like this was fixed in 
https://github.com/apache/nifi-minifi-cpp/commit/9a3616ff1557eb9d35a8a3c477b8ae6954808021#diff-8838aae70901899c9da68b92dbe0a0209a9aaeb6565af72cefbe088b6a377f51R422



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org