[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1424: MINIFICPP-1862 use std::filesystem::path instead of std::string where appropriate

[GitBox]

martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044566428


##########
extensions/sftp/processors/FetchSFTP.cpp:
##########
@@ -87,12 +87,11 @@ void FetchSFTP::onTrigger(const 
std::shared_ptr<core::ProcessContext> &context,
     return;
   }
 
-  /* Parse processor-specific properties */
-  std::string remote_file;
-  std::string move_destination_directory;
-
-  context->getProperty(RemoteFile, remote_file, flow_file);
-  context->getProperty(MoveDestinationDirectory, move_destination_directory, 
flow_file);
+  std::string path_str;
+  context->getProperty(RemoteFile, path_str, flow_file);
+  auto remote_file = std::filesystem::path(path_str, 
std::filesystem::path::format::generic_format);
+  context->getProperty(MoveDestinationDirectory, path_str, flow_file);

Review Comment:
   great catch, reworked this in 
https://github.com/apache/nifi-minifi-cpp/pull/1424/commits/6c775d116236c92105c7be38bb284f309c27887c#diff-1681c2dbfafc5cbbb437de97c560fabdb639b547d6a368f3e65c8e6c5c03d3ecR90-R98



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org