szaszm commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r1120572943
##########
extensions/rocksdb-repos/FlowFileRepository.cpp:
##########
@@ -200,6 +200,20 @@ bool FlowFileRepository::initialize(const
std::shared_ptr<Configure> &configure)
}
logger_->log_debug("NiFi FlowFile Repository Directory %s", directory_);
+ compaction_period_ = DEFAULT_COMPACTION_PERIOD;
+ if (auto compaction_period_str =
configure->get(Configure::nifi_flowfile_repository_compaction_period)) {
+ if (auto compaction_period =
TimePeriodValue::fromString(compaction_period_str.value())) {
+ compaction_period_ = compaction_period->getMilliseconds();
+ if (compaction_period_.count() == 0) {
+ logger_->log_warn("Setting '%s' to 0 disables forced compaction",
Configure::nifi_dbcontent_repository_compaction_period);
+ }
+ } else {
+ logger_->log_error("Malformed property '%s', expected time period, using
default", Configure::nifi_flowfile_repository_compaction_period);
+ }
+ } else {
+ logger_->log_info("Using default compaction period");
Review Comment:
I think this can use a lower log level. It would also be nice to include the
value of this default.
```suggestion
logger_->log_debug("Using default compaction period of %" PRId64 " ms",
compaction_period_.count());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
