szaszm commented on PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#issuecomment-1450037284
One last comment: the clang-tidy is failing the CI, because you changed
OpenRocksDb.cpp, and it wants us to concatenate the namespace blocks.
```
extensions/rocksdb-repos/database/OpenRocksDb.cpp:25:1: error: nested
namespaces can be concatenated
[modernize-concat-nested-namespaces,-warnings-as-errors]
namespace org {
^~~~~~~~~~~~~~~
namespace org::apache::nifi::minifi::internal
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
