fgerlits commented on code in PR #1483: URL: https://github.com/apache/nifi-minifi-cpp/pull/1483#discussion_r1135691120
########## PROCESSORS.md: ########## @@ -749,16 +885,15 @@ Fetches a file from a Google Cloud Bucket. Designed to be used in tandem with Li In the list below, the names of required properties appear in bold. Any other properties (not in bold) are considered optional. The table also indicates any default values, and whether a property supports the NiFi Expression Language. -| Name | Default Value | Allowable Values | Description | -|--------------------------------------|---------------|-----------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------| -| **Bucket** | ${gcs.bucket} | | Bucket of the object.<br>**Supports Expression Language: true** | -| **Key** | ${filename} | | Name of the object.<br>**Supports Expression Language: true** | -| **Number of retries** | 6 | integers | How many retry attempts should be made before routing to the failure relationship. | -| **GCP Credentials Provider Service** | | [GCPCredentialsControllerService](CONTROLLERS.md#GCPCredentialsControllerService) | The Controller Service used to obtain Google Cloud Platform credentials. | -| Server Side Encryption Key | | | An AES256 Encryption Key (encoded in base64) for server-side encryption of the object.<br>**Supports Expression Language: true** | -| Object Generation | | | The generation of the Object to download. If left empty, then it will download the latest generation.<br>**Supports Expression Language: true** | -| Endpoint Override URL | | | Overrides the default Google Cloud Storage endpoints | - +| Name | Default Value | Allowable Values | Description | +|--------------------------------------|---------------|------------------|--------------------------------------------------------------------------------------------------------------------------------------------------| +| **GCP Credentials Provider Service** | | | The Controller Service used to obtain Google Cloud Platform credentials. | +| **Number of retries** | 6 | | How many retry attempts should be made before routing to the failure relationship. | +| Endpoint Override URL | | | Overrides the default Google Cloud Storage endpoints<br/>**Supports Expression Language: true** | +| Bucket | ${gcs.bucket} | | Bucket of the object.<br/>**Supports Expression Language: true** | +| Key | ${filename} | | Name of the object.<br/>**Supports Expression Language: true** | +| Server Side Encryption Key | | | The AES256 Encryption Key (encoded in base64) for server-side decryption of the object.<br/>**Supports Expression Language: true** | Review Comment: Since this is in `FetchGCSObject`, I think "decryption" is correct, and "encryption" was a typo. @martinzink please correct me if I'm wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org