markap14 commented on code in PR #7003: URL: https://github.com/apache/nifi/pull/7003#discussion_r1142710823
########## nifi-nar-bundles/nifi-py4j-bundle/nifi-python-extension-api/src/main/python/src/nifiapi/flowfiletransform.py: ########## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from abc import ABC, abstractmethod +from nifiapi.__jvm__ import JvmHolder +from nifiapi.properties import ProcessContext + + +class FlowFileTransform(ABC): Review Comment: This gets complicated when it comes to automatically detecting extensions. The method employed currently is probably not a great solution. But with my limited Python understanding, it works. It's using the abstract syntax tree from parsing the class. Which means that it's looking for this in particular. We could probably change the AST to instead look for inheriting from `FlowFileTransform` but that could then be aliased in the import, etc. so that complicates things. As noted, I expect all of this to evolve over time. Just want to get something in the hands of users for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
