briansolo1985 commented on code in PR #7125: URL: https://github.com/apache/nifi/pull/7125#discussion_r1159936286
########## c2/c2-client-bundle/c2-client-http/src/main/java/org/apache/nifi/c2/client/http/url/C2UrlProviderFactory.java: ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.c2.client.http.url; + +import static org.apache.commons.lang3.StringUtils.isNoneBlank; + +import org.apache.nifi.c2.client.C2ClientConfig; + +public class C2UrlProviderFactory { + + private final C2ClientConfig clientConfig; + + public C2UrlProviderFactory(C2ClientConfig clientConfig) { + this.clientConfig = clientConfig; + } + + public C2UrlProvider create() { + if (isNoneBlank(clientConfig.getC2RestApi(), clientConfig.getC2RestPathHeartbeat(), clientConfig.getC2RestPathAcknowledge())) { + return new ProxyAwareC2UrlProvider(clientConfig.getC2RestApi(), clientConfig.getC2RestPathHeartbeat(), clientConfig.getC2RestPathAcknowledge()); + } else if (isNoneBlank(clientConfig.getC2Url(), clientConfig.getC2AckUrl())) { + return new LegacyC2UrlProvider(clientConfig.getC2Url(), clientConfig.getC2AckUrl()); + } else { + throw new IllegalArgumentException("Incorrect configuration. Please configure legacy or proxy aware C2 URL properties"); Review Comment: Added a more detailed error message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
