briansolo1985 commented on code in PR #7125:
URL: https://github.com/apache/nifi/pull/7125#discussion_r1160101758
##########
c2/c2-client-bundle/c2-client-base/src/main/java/org/apache/nifi/c2/client/C2ClientConfig.java:
##########
@@ -23,6 +23,9 @@ public class C2ClientConfig {
private final String c2Url;
private final String c2AckUrl;
+ private final String c2RestApi;
Review Comment:
Renamed as advised - went with the second option
##########
c2/c2-client-bundle/c2-client-http/src/main/java/org/apache/nifi/c2/client/http/url/ProxyAwareC2UrlProvider.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.c2.client.http.url;
+
+import static org.apache.commons.lang3.StringUtils.isNotBlank;
+
+import java.net.MalformedURLException;
+import java.net.URL;
+
+public class ProxyAwareC2UrlProvider implements C2UrlProvider {
+
+ private final String c2RestApi;
+ private final String c2RestPathHeartbeat;
+ private final String c2RestPathAcknowledge;
+
+ ProxyAwareC2UrlProvider(String c2RestApi, String c2RestPathHeartbeat,
String c2RestPathAcknowledge) {
+ this.c2RestApi = c2RestApi;
+ this.c2RestPathHeartbeat = c2RestPathHeartbeat;
+ this.c2RestPathAcknowledge = c2RestPathAcknowledge;
+ }
+
+ @Override
+ public String getHeartbeatUrl() {
+ return toAbsoluteUrl(c2RestPathHeartbeat);
Review Comment:
Moved the logic to the constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
