fgerlits commented on code in PR #1589:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1589#discussion_r1259928495
##########
extensions/standard-processors/tests/unit/ReplaceTextTests.cpp:
##########
@@ -93,7 +93,7 @@ TEST_CASE("Regex Replace works correctly in ReplaceText",
"[applyReplacements][R
replace_text.setSearchRegex("a\\w+e");
replace_text.setReplacementValue("orange");
- CHECK(replace_text.applyReplacements("") == "");
Review Comment:
I'm not a fan of this, as the block would have to span multiple test cases,
and apply to just one line in each test case. I think individual `NOLINT`s are
OK. I would also be fine with disabling this check completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
