fgerlits commented on code in PR #1589: URL: https://github.com/apache/nifi-minifi-cpp/pull/1589#discussion_r1259934099
########## libminifi/include/core/OutputAttributeDefinition.h: ########## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <array> +#include <string_view> + +#include "utils/gsl.h" +#include "RelationshipDefinition.h" + +namespace org::apache::nifi::minifi::core { + +template<size_t NumRelationships = 1> +struct OutputAttributeDefinition { + constexpr OutputAttributeDefinition(std::string_view name, std::array<RelationshipDefinition, NumRelationships> relationships, std::string_view description) + : name(name), + relationships(relationships), + description(description) { + } + + std::string_view name; + std::array<RelationshipDefinition, NumRelationships> relationships; + std::string_view description; +}; + +struct OutputAttributeReference { + constexpr OutputAttributeReference() = default; // TODO(fgerlits): is this needed? Review Comment: Unfortunately it is, because VS 2019 cannot construct an empty `OutputAttributeReference` array if there is no default constructor. I have replaced the TODO with a comment explaining this in 3c761849296b1fed6b74d08fc731a4e9044d54d0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
