fgerlits commented on code in PR #1589:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1589#discussion_r1265636500
##########
libminifi/include/core/PropertyType.h:
##########
@@ -90,12 +47,19 @@ class PropertyValidator {
[[nodiscard]] virtual ValidationResult validate(const std::string &subject,
const std::shared_ptr<minifi::state::response::Value> &input) const = 0;
[[nodiscard]] virtual ValidationResult validate(const std::string &subject,
const std::string &input) const = 0;
+};
+
+class PropertyType : public PropertyParser, public PropertyValidator {
Review Comment:
On the 2nd part: good catch, thanks! We can't change the validator names we
send to C2. I have reverted them in 1f9cd0bf0dd802b61175e670dba59d4e0ca2fb25.
On the 1st part: this is not really multiple inheritance, just a separation
of two interfaces. Are you sure we want to replace 12 classes, each
implementing two interfaces, with 36 classes using composition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
