fgerlits commented on code in PR #1589:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1589#discussion_r1267693191
##########
libminifi/include/core/PropertyType.h:
##########
@@ -90,12 +47,19 @@ class PropertyValidator {
[[nodiscard]] virtual ValidationResult validate(const std::string &subject,
const std::shared_ptr<minifi::state::response::Value> &input) const = 0;
[[nodiscard]] virtual ValidationResult validate(const std::string &subject,
const std::string &input) const = 0;
+};
+
+class PropertyType : public PropertyParser, public PropertyValidator {
Review Comment:
as discussed offline, I have renamed `getName()` to `getValidatorName()` in
b052e55ef42515d9ef441975cf1188e95c9625f0
(675e2a662b66d1330690873e6fe9b006eee51670 after the rebase)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
