lordgamez commented on code in PR #1631:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1631#discussion_r1305367395
##########
libminifi/include/core/logging/LoggerConfiguration.h:
##########
@@ -98,15 +98,15 @@ class LoggerConfiguration {
*/
void initialize(const std::shared_ptr<LoggerProperties> &logger_properties);
- static std::unique_ptr<io::InputStream> getCompressedLog(bool flush = false)
{
- return getCompressedLog(std::chrono::milliseconds{0}, flush);
+ static std::vector<std::unique_ptr<io::InputStream>> getCompressedLogs(bool
flush = false) {
+ return getCompressedLogs(std::chrono::milliseconds{0}, flush);
Review Comment:
Yes, that was the approach I tried in a previous commit, but the logger test
with multiple segments failed with this implementation.
https://github.com/lordgamez/nifi-minifi-cpp/commit/2f3d2c0800f5b9fc29e3f3fde64dbcd8d9ede283
I tried modifying the `ZlibDecompressStream` class to be able to handle this
kind of `InputStreamBundle` but evenn if I try to adjust the zlib libraries
`z_stream` input and output pointers the decompression after the first segment
still fails to read the proper data:
https://github.com/lordgamez/nifi-minifi-cpp/commit/7ac83b33051fe672f984d0885c198b3baa07e1d6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
