szaszm commented on code in PR #1631: URL: https://github.com/apache/nifi-minifi-cpp/pull/1631#discussion_r1329636177
########## libminifi/include/core/logging/LoggerConfiguration.h: ########## @@ -98,15 +98,15 @@ class LoggerConfiguration { */ void initialize(const std::shared_ptr<LoggerProperties> &logger_properties); - static std::unique_ptr<io::InputStream> getCompressedLog(bool flush = false) { - return getCompressedLog(std::chrono::milliseconds{0}, flush); + static std::vector<std::unique_ptr<io::InputStream>> getCompressedLogs(bool flush = false) { + return getCompressedLogs(std::chrono::milliseconds{0}, flush); Review Comment: I was hoping for some code simplification, but since it's not trivial, I don't want to block this PR with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org