martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1339765522
##########
extensions/http-curl/client/HTTPCallback.h:
##########
@@ -142,8 +142,8 @@ class HttpStreamingCallback final : public
utils::HTTPUploadByteArrayInputCallba
current_buffer_start_ = total_bytes_loaded_;
current_pos_ = current_buffer_start_;
total_bytes_loaded_ += current_vec_.size();
- logger_->log_trace("loadNextBuffer() loaded new buffer, ptr_: %p, size:
%zu, current_buffer_start_: %zu, current_pos_: %zu, total_bytes_loaded_: %zu",
- ptr_,
+ logger_->log_trace("loadNextBuffer() loaded new buffer, ptr_: {}, size:
{}, current_buffer_start_: {}, current_pos_: {}, total_bytes_loaded_: {}",
+ static_cast<void*>(ptr_),
Review Comment:
its a feature of fmt and std::format they only accept void* for printing out
pointers so we dont accidentaly write
something like this:
https://github.com/apache/nifi-minifi-cpp/blame/main/libminifi/src/controllers/SSLContextService.cpp#L225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
