[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1670: MINIFICPP-2220 Change core::logging::Logger to use fmt format

[via GitHub]

martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1341084547


##########
libminifi/src/sitetosite/RawSocketProtocol.cpp:
##########
@@ -435,8 +431,8 @@ int RawSiteToSiteClient::readRespond(const 
std::shared_ptr<Transaction> &transac
   return readResponse(transaction, code, message);
 }
 
-int RawSiteToSiteClient::writeRespond(const std::shared_ptr<Transaction> 
&transaction, RespondCode code, std::string message) {
-  return writeResponse(transaction, code, std::move(message));
+int RawSiteToSiteClient::writeRespond(const std::shared_ptr<Transaction> 
&transaction, RespondCode code, const std::string& message) {
+  return writeResponse(transaction, code, message);

Review Comment:
   Changing that properly would lead further than I would like in this PR (this 
leads to a call to `size_t OutputStream::write(const std::string& str, bool 
widen = false);`)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org