exceptionfactory commented on code in PR #7661:
URL: https://github.com/apache/nifi/pull/7661#discussion_r1342717006
##########
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy:
##########
@@ -722,7 +707,7 @@ class ConfigEncryptionTool {
final PropertyEncryptor inputEncryptor = new
PropertyEncryptorBuilder(existingFlowPassword).setAlgorithm(existingAlgorithm).build()
final PropertyEncryptor outputEncryptor = new
PropertyEncryptorBuilder(newFlowPassword).setAlgorithm(newAlgorithm).build()
- final FlowEncryptor flowEncryptor = new StandardFlowEncryptor()
+ final FlowEncryptor flowEncryptor = new XmlFlowEncryptor()
Review Comment:
Thanks for the reply and clarifying the implementations. In this case, it
looks like the implementation should be changed to the JsonFlowEncryptor. The
`migrateFlowXmlContent()` method can be renamed to `migrateFlowContent()` and
that seems sufficient for this PR. How does that sound?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
