exceptionfactory commented on code in PR #7661:
URL: https://github.com/apache/nifi/pull/7661#discussion_r1342713418
##########
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy:
##########
@@ -248,8 +235,6 @@ class ConfigEncryptionTool {
options.addOption(Option.builder("i").longOpt(OUTPUT_LOGIN_IDENTITY_PROVIDERS_ARG).hasArg(true).argName("file").desc("The
destination login-identity-providers.xml file containing protected config
values (will not modify input login-identity-providers.xml)").build())
options.addOption(Option.builder("a").longOpt(AUTHORIZERS_ARG).hasArg(true).argName("file").desc("The
authorizers.xml file containing unprotected config values (will be overwritten
unless -u is specified)").build())
options.addOption(Option.builder("u").longOpt(OUTPUT_AUTHORIZERS_ARG).hasArg(true).argName("file").desc("The
destination authorizers.xml file containing protected config values (will not
modify input authorizers.xml)").build())
-
options.addOption(Option.builder("f").longOpt(FLOW_XML_ARG).hasArg(true).argName("file").desc("The
flow.xml.gz file currently protected with old password (will be overwritten
unless -g is specified)").build())
-
options.addOption(Option.builder("g").longOpt(OUTPUT_FLOW_XML_ARG).hasArg(true).argName("file").desc("The
destination flow.xml.gz file containing protected config values (will not
modify input flow.xml.gz)").build())
Review Comment:
Thanks for the reply @simonbence. Handling the toolkit changes in a separate
PR sounds good, but in that case, I recommend reverting this particular removal
and keeping the toolkit changes as minimal as possible. As these argument names
do not impact actual flow.xml.gz usage, leaving them in place seems fine for
now, and more substantive changes can be handled separately. So from that
perspective, I recommend limiting the toolkit changes to only those that are
required for the removal of actual flow.xml.gz handling code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
