[ 
https://issues.apache.org/jira/browse/NIFI-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772579#comment-17772579
 ] 

David Handermann commented on NIFI-12178:
-----------------------------------------

Thanks for taking on this effort [~Chris S], I think this would be a very 
helpful improvement.

Handling integration tests may be somewhat challenging, as some work on their 
own with or without Testcontainers, but others require manual adjust for 
credentials. This could be a good opportunity to remove some stale integration 
tests. It may be worth separating the effort into Docker workflow builds and 
integration test builds depending on the types of changes required. JUnit 5 
also provides some new annotations for conditional enabling based on 
environment variables or system properties. This could be used to filter and 
select integration tests that do not need any additional configuration or 
external properties. This could also support adjusting some integration tests 
to use system properties instead of relying on manual changes to set properties 
like credentials and URLs.

> Add integration-tests and docker-tests GithHub Action Workflows
> ---------------------------------------------------------------
>
>                 Key: NIFI-12178
>                 URL: https://issues.apache.org/jira/browse/NIFI-12178
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Chris Sampson
>            Assignee: Chris Sampson
>            Priority: Major
>             Fix For: 2.latest
>
>
> There are a lot of {{integration-tests}} and {{docker}} builds in the NiFi 
> repository that aren't being regularly executed and verified.
> GitHub Action Workflows should be added (similar to the existing 
> {{system-tests}} Workflow) that regularly exercise these tests, allowing the 
> community to better monitor the health of NiFi components.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to