[ 
https://issues.apache.org/jira/browse/NIFI-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772587#comment-17772587
 ] 

Chris Sampson commented on NIFI-12178:
--------------------------------------

[~exceptionfactory] I started off by trying to run all of the tests/builds 
together, but have separated them into their own workflows 
({{integration-tests}} and {{docker-tests}}) now due to disk space issues more 
than anything else.

My approach currently is:
* build and test Docker Images (which is working for an Ubuntu runner, but not 
MacOS as that doesn't come with Docker installed - we can install Colima but 
the {{nifi-docker}} tests fail, which I propose to be handled by NIFI-12177 in 
future)
* build and run all {{integration-tests}} that aren't already covered by the 
existing {{system-tests}} workflow
** I've identified a lot of failures/errors already, but rather than trying to 
fix them (other than general issues like not having Docker running), I'm 
filtering out the {{IT}} classes from the [failsafe 
plugin|https://maven.apache.org/surefire/maven-failsafe-plugin/examples/single-test.html#multiple-formats-in-one]
 execution
** this will give us a list of failing test classes and/or methods (some 
classes have tests that pass but others are failing), which we can look to 
diagnose and fix as part of a follow-on ticket in the future

This feels like a sensible/iterative approach to getting something running in 
GitHub to prevent deterioration of existing ITs, capture any new ITs added in 
future, and allow us to find and remove/fix existing failing ITs already in the 
repository.

Open to suggestions on a different approach if you/anyone has other ideas 
(ongoing trials can be seen in my fork at 
https://github.com/ChrisSamo632/nifi/actions)

> Add integration-tests and docker-tests GithHub Action Workflows
> ---------------------------------------------------------------
>
>                 Key: NIFI-12178
>                 URL: https://issues.apache.org/jira/browse/NIFI-12178
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Chris Sampson
>            Assignee: Chris Sampson
>            Priority: Major
>             Fix For: 2.latest
>
>
> There are a lot of {{integration-tests}} and {{docker}} builds in the NiFi 
> repository that aren't being regularly executed and verified.
> GitHub Action Workflows should be added (similar to the existing 
> {{system-tests}} Workflow) that regularly exercise these tests, allowing the 
> community to better monitor the health of NiFi components.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to