ChrisSamo632 commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1350393878
##########
.github/workflows/system-tests.yml:
##########
@@ -64,71 +64,45 @@ env:
-pl nifi-system-tests/nifi-system-test-suite
-pl nifi-system-tests/nifi-stateless-system-test-suite
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
permissions:
contents: read
jobs:
- ubuntu:
+ build_and_test:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ ubuntu-latest, macos-latest ]
+ version: [ 21 ]
timeout-minutes: 120
- runs-on: ubuntu-latest
- name: Ubuntu Corretto Java 21
+ runs-on: ${{ matrix.os }}
+ name: ${{ matrix.os }} Java ${{ matrix.version }}
+ env:
+ # default to Amazon Corretto JDK
+ JAVA_DISTRIBUTION: corretto
steps:
+ # Zulu JDK appears to be more reliable for MacOS
+ - name: Use Java distribution Zulu
+ if: ${{ runner.os == 'macos' }}
+ run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV"
Review Comment:
You'd have hoped so. Apparently there was a `set-env` action a while back,
but that was deemed unsafe to use, so this appears to be the GitHub suggested
way to achieve this between steps - see
https://docs.github.com/en/actions/learn-github-actions/variables#passing-values-between-steps-and-jobs-in-a-workflow
Open to other/better approaches if you find one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
