ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350406115
########## .github/workflows/docker-tests.yml: ########## @@ -0,0 +1,164 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: docker-tests + +on: + # Run every day at 02:00 + schedule: + - cron: "0 2 * * *" + push: + paths: + - '.github/workflows/docker-tests.yml' + - 'nifi-assembly/**' + - 'nifi-docker/**' + - 'nifi-registry/nifi-registry-assembly/**' + - 'nifi-registry/nifi-registry-docker-maven/**' + - 'minifi/minifi-assembly/**' + - 'minifi/minifi-docker/**' + - 'minifi/minifi-c2/minifi-c2-assembly/**' + - 'minifi/minifi-c2/minifi-c2-docker/**' + pull_request: + paths: + - '.github/workflows/docker-tests.yml' + - 'nifi-assembly/**' + - 'nifi-docker/**' + - 'nifi-registry/nifi-registry-assembly/**' + - 'nifi-registry/nifi-registry-docker-maven/**' + - 'minifi/minifi-assembly/**' + - 'minifi/minifi-docker/**' + - 'minifi/minifi-c2/minifi-c2-assembly/**' + - 'minifi/minifi-c2/minifi-c2-docker/**' + +env: + DEFAULT_MAVEN_OPTS: >- + -Xmx4g + -XX:ReservedCodeCacheSize=1g + -XX:+UseG1GC + -Dorg.slf4j.simpleLogger.defaultLogLevel=WARN + -Daether.connector.http.retryHandler.count=5 + -Daether.connector.http.connectionMaxTtl=30 + MAVEN_COMMAND: >- + ./mvnw + -V + -nsu + -ntp + -ff + +# build assemblies (including binaries) for use in Docker Image builds + MAVEN_BUILD_ARGUMENTS: >- + -am + -D skipTests + -T 2.0C + package + MAVEN_BUILD_PROJECTS: >- + -pl nifi-assembly + -pl nifi-registry/nifi-registry-assembly + -pl nifi-toolkit/nifi-toolkit-assembly + -pl minifi/minifi-assembly + -pl minifi/minifi-c2/minifi-c2-assembly + + MAVEN_CLEAN_ARGUMENTS: >- + -T 2.0C + clean + MAVEN_CLEAN_PROJECTS: >- + -pl -nifi-assembly + -pl -nifi-registry/nifi-registry-assembly + -pl -nifi-toolkit/nifi-toolkit-assembly + -pl -minifi/minifi-assembly + -pl -minifi/minifi-c2/minifi-c2-assembly + +# build and test Docker Images + MAVEN_DOCKER_ARGUMENTS: >- + install + -P docker + MAVEN_DOCKER_PROJECTS: >- + -pl minifi/minifi-docker + -pl minifi/minifi-c2/minifi-c2-docker + -pl nifi-docker/dockermaven + -pl nifi-registry/nifi-registry-docker-maven/dockermaven + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +permissions: + contents: read + +jobs: + build_and_test: + strategy: + fail-fast: false + matrix: + # TODO: macos-latest doesn't come with Docker and Colima seems to have problems with the nifi-docker integration_test scripts - see NIFI-12177/NIFI-12191 + os: [ ubuntu-latest ] + version: [ 21 ] + timeout-minutes: 120 + runs-on: ${{ matrix.os }} + name: ${{ matrix.os }} Java ${{ matrix.version }} + env: + # default to Amazon Corretto JDK + JAVA_DISTRIBUTION: corretto + steps: + # Zulu JDK appears to be more reliable for MacOS + - name: Use Java distribution Zulu + if: ${{ runner.os == 'macos' }} + run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV" + - name: Checkout Code + uses: actions/checkout@v4 + - name: Set up Java ${{ env.JAVA_DISTRIBUTION }} ${{ matrix.version }} + uses: actions/setup-java@v3 + with: + distribution: ${{ env.JAVA_DISTRIBUTION }} + java-version: ${{ matrix.version }} + cache: 'maven' + + - name: Set up Docker + if: ${{ runner.os == 'macos' }} + run: |- + /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" + brew install docker + colima start + + if [ ! -e /var/run/docker.sock ]; then sudo ln -s ~/.colima/docker.sock /var/run/docker.sock; fi + - name: Confirm Docker + run: id && docker info + + - name: Build Assemblies + env: + MAVEN_OPTS: >- + ${{ env.DEFAULT_MAVEN_OPTS }} + run: > + ${{ env.MAVEN_COMMAND }} + ${{ env.MAVEN_BUILD_ARGUMENTS }} + ${{ env.MAVEN_BUILD_PROJECTS }} + - name: Clean Modules + env: + MAVEN_OPTS: >- + ${{ env.DEFAULT_MAVEN_OPTS }} + # clean non-assembly modules before running Docker builds and delete unpacked binaries, otherwise we'll run out of disk space + run: > + ${{ env.MAVEN_COMMAND }} + ${{ env.MAVEN_CLEAN_ARGUMENTS }} + ${{ env.MAVEN_CLEAN_PROJECTS }} + && rm -rf nifi-assembly/target/nifi-*-bin/ nifi-registry/nifi-registry-assembly/target/nifi-registry-*-bin/ Review Comment: We need the binaries, but only the Zip file versions, these `rm` commands remove the unzipped directories from `target` (which exist prior to the `.zip` being created by the assembly plugin) This *may not* be required for the space saving any longer, but I had a lot of issues with disk space during development, so deleting unnecessary files between steps seemed most sensible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
