szaszm commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1356620166
##########
extensions/windows-event-log/CollectorInitiatedSubscription.cpp:
##########
@@ -481,7 +486,7 @@ bool CollectorInitiatedSubscription::subscribe(const
std::shared_ptr<core::Proce
if (!EvtRender(NULL, hEvent, EvtRenderEventXml, size, 0, &used,
&propertyCount)) {
if (ERROR_INSUFFICIENT_BUFFER == GetLastError()) {
if (used >
pCollectorInitiatedSubscription->max_buffer_size_.getValue()) {
- logger->log_error("Dropping event %p because it couldn't be
rendered within %llu bytes.", hEvent,
pCollectorInitiatedSubscription->max_buffer_size_.getValue());
+ logger->log_error("Dropping event {} because it couldn't be
rendered within {} bytes.", hEvent,
pCollectorInitiatedSubscription->max_buffer_size_.getValue());
Review Comment:
The other log uses the `{:#x}` format specifier, while this just uses the
default `{}` for the same handle. Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
