martinzink commented on code in PR #1670:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1670#discussion_r1356661024
##########
libminifi/test/TestBase.cpp:
##########
@@ -59,7 +59,7 @@ std::shared_ptr<LogTestController>
LogTestController::getInstance(const std::sha
void LogTestController::setLevel(std::string_view name,
spdlog::level::level_enum level) {
const auto levelView(spdlog::level::to_string_view(level));
- logger_->log_info("Setting log level for %s to %s", std::string(name),
std::string(levelView.begin(), levelView.end()));
+ logger_->log_info("Setting log level for {} to {}", std::string(name),
std::string(levelView.begin(), levelView.end()));
Review Comment:
:+1:
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/6a5aebd7790dbf83d5418c03b6168ae3a0b6bf38#diff-90730063bb5cd6c614c0a28440ffe3223775f73126b426a0059eff1957b5b1c8R62
##########
libminifi/src/utils/net/AsioSocketUtils.cpp:
##########
@@ -72,18 +72,18 @@ bool AsioSocketConnection::connectTcpSocketOverSsl() {
asio::error_code err;
asio::ip::tcp::resolver::results_type endpoints =
resolver.resolve(socket_data_.host, std::to_string(socket_data_.port), err);
if (err) {
- logger_->log_error("Resolving host '%s' on port '%s' failed with the
following message: '%s'", socket_data_.host, std::to_string(socket_data_.port),
err.message());
+ logger_->log_error("Resolving host '{}' on port '{}' failed with the
following message: '{}'", socket_data_.host, std::to_string(socket_data_.port),
err.message());
Review Comment:
:+1:
https://github.com/apache/nifi-minifi-cpp/pull/1670/commits/6a5aebd7790dbf83d5418c03b6168ae3a0b6bf38#diff-1c49ef68c8086eafeeba05f851885876f763cbb327cc8103c6a3a5d8460246a8L75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
