ChrisSamo632 commented on code in PR #7995:
URL: https://github.com/apache/nifi/pull/7995#discussion_r1386290226
##########
pom.xml:
##########
@@ -29,6 +29,7 @@
<module>nifi-framework-api</module>
<module>nifi-server-api</module>
<module>nifi-bootstrap</module>
+ <module>nifi-code-coverage</module>
Review Comment:
I think the other possibie option, to avoid the new `nifi-code-coverage`
sub-module, which may become out of step when new things are added to the repo,
would be to add:
```xml
<properties>
<jacoco.skip>true</jacoco.skip>
</properties>
```
to all sub-modules where we don't want to collect coverage, e.g. NAR and
Bundle sub-modules. So this would remove the need for a new sub-module to
maintain, but would mean updating lots of other existing sub-modules instead,
then people understanding when to include the `skip` property for new
sub-modules in future.
I don't think either option is ideal, but thought I'd raise the alternative
for consideration - I'd be happy with either considered option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
