exceptionfactory commented on code in PR #7995:
URL: https://github.com/apache/nifi/pull/7995#discussion_r1386624819
##########
.github/workflows/ci-workflow.yml:
##########
@@ -160,22 +159,19 @@ jobs:
${{ env.MAVEN_COMPILE_COMMAND }}
- name: Maven Verify
env:
- NIFI_CI_LOCALE: >-
- -Duser.language=en
- -Duser.country=AU
- SUREFIRE_OPTS: >-
Review Comment:
I considered similar options as described in the
[prepare-agent](https://www.jacoco.org/jacoco/trunk/doc/prepare-agent-mojo.html)
goal documentation, but part of the difficulty is that the build workflow was
setting a System property, which JaCoCo also needs to set. We could change the
System property in the build workflow to a different name, and then use that
name for late property evaluation in the maven-surefire-plugin configuration,
but that would have involved changes all of the build profiles. I kept the
scope of changes narrow in this case, but we could revisit in the future if we
need to introduce other arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
