simonbence commented on PR #8152: URL: https://github.com/apache/nifi/pull/8152#issuecomment-1853298122
> Thanks for creating the new pull request and making the adjustments @simonbence. I have yet not review the entire implementation, but I noted a few recommendations. > > Having this in a separate module and avoiding changes to the nifi-api is helpful. I am not sure about the general reuse of the retry interfaces, so I'm not sure whether it warrants adding them to `nifi-utils`. Perhaps they would be better in a separate `nifi-retry-utils` under `nifi-commons`, or just kept as part of the QuestDB module in a separate package until it gets to the point where they could be reused. I hope this PR will be more fit to go on with :) As of retry: even if it is currently used only by the QuestDB module, I would consider it as a general util or tool, just like other parts of the given module, like for example the `InputStream` implementations. The concept is simple and might be applied in many place and I think we would benefit from having one extracted and tested code piece do this work if necessary. So I would not think moving it to the QuestDB module would be the right way but if you insist, I can separate it to a distinct module under `nifi-commons` (however I think that would be a bit of an exaggeration). Please share your thoughts, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
