exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1435323896
##########
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/retry/NoReturnCallable.java:
##########
@@ -14,25 +14,16 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.nifi.controller.status.history.storage;
-
-import org.apache.nifi.controller.status.history.GarbageCollectionHistory;
-import org.apache.nifi.controller.status.history.GarbageCollectionStatus;
-
-import java.time.Instant;
+package org.apache.nifi.retry;
/**
- * Readable status storage for garbage collection status entries.
+ * Represents a portion of callable code without expected return value.
*/
-public interface GarbageCollectionStatusStorage extends
StatusStorage<GarbageCollectionStatus> {
+@FunctionalInterface
+public interface NoReturnCallable {
Review Comment:
Thanks for the additional background. With that in mind, it seems like
having the custom `Callable` as a nested interface on the RetryTemplate would
be a better approach.
Did you consider using
[spring-retry](https://www.baeldung.com/spring-retry#retrytemplate) instead?
Since the abstraction applies to QuestDB, it seems worth considering as it has
a minimal number of dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
