[ 
https://issues.apache.org/jira/browse/NIFI-12554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801401#comment-17801401
 ] 

David Handermann commented on NIFI-12554:
-----------------------------------------

Thanks for evaluating the options [~dstiegli1].

It sounds like this is an opportunity to move both processors to a new shared 
module along the following lines:

- nifi-jolt-bundle
- nifi-jolt-processors
- nifi-jolt-nar

This would be a breaking changes strictly speaking in terms of moving things to 
a new NAR, but it aligns with the goals of NIFI-11171 for NiFi 2.0 to 
reorganize some of the standard processors. Any of these moves should be 
evaluated on a case-by-case basis, but as Jolt is called out as one in 
particular, this seems to be the best approach, rather than introducing new 
modules under nifi-commons, or in some other location.

> Refactor JoltTransformJSON and JoltTransformRecord processors in order to 
> reduce duplicate code
> -----------------------------------------------------------------------------------------------
>
>                 Key: NIFI-12554
>                 URL: https://issues.apache.org/jira/browse/NIFI-12554
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Major
>
> There is a lot of duplicate code between the JoltTransformJSON and 
> JoltTransformRecord processors. As a result each time there is a bug 
> discovered in the duplicate code there has to be a fix applied in both places 
> (e.g. NIFI-11959 and NIFI-12165).  This ticket aims to pull up the common 
> code between JoltTransformJSON and JoltTransformRecord similar to what has 
> been done for PutElastisearchJSON and PutElastisearchRecord processors with 
> the creation of AbstractPutElasticsearch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to