[ 
https://issues.apache.org/jira/browse/NIFI-12554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804467#comment-17804467
 ] 

Daniel Stieglitz commented on NIFI-12554:
-----------------------------------------

[~exceptionfactory] Another point I noticed the following is declared in both 
JoltTransformJSON and JoltTransformRecord

{code:java}
private Cache<Optional<String>, JoltTransform> transformCache;
{code}

I do not see it being declared volatile like other variables used in the setUp 
method in JolTransformJSON. Was this on purpose or perhaps an oversight?


> Refactor JoltTransformJSON and JoltTransformRecord processors in order to 
> reduce duplicate code
> -----------------------------------------------------------------------------------------------
>
>                 Key: NIFI-12554
>                 URL: https://issues.apache.org/jira/browse/NIFI-12554
>             Project: Apache NiFi
>          Issue Type: Sub-task
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Major
>
> There is a lot of duplicate code between the JoltTransformJSON and 
> JoltTransformRecord processors. As a result each time there is a bug 
> discovered in the duplicate code there has to be a fix applied in both places 
> (e.g. NIFI-11959 and NIFI-12165).  This ticket aims to pull up the common 
> code between JoltTransformJSON and JoltTransformRecord similar to what has 
> been done for PutElastisearchJSON and PutElastisearchRecord processors with 
> the creation of AbstractPutElasticsearch.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to