szaszm commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1446385712
########## LICENSE: ########## @@ -2442,52 +2443,6 @@ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -This product bundles 'protobuf' within 'OpenCV' under a 3-Clause BSD license: Review Comment: Is it no longer enabled within OpenCV? ########## .dockerignore: ########## @@ -57,6 +57,11 @@ extensions/expression-language/Scanner.cpp extensions/expression-language/location.hh extensions/expression-language/position.hh extensions/expression-language/stack.h +extensions/grafana-loki/protobuf-generated/grafana-loki-push.grpc.pb.h +extensions/grafana-loki/protobuf-generated/grafana-loki-push.grpc.pb.cc +extensions/grafana-loki/protobuf-generated/grafana-loki-push.pb.h +extensions/grafana-loki/protobuf-generated/grafana-loki-push.pb.cc Review Comment: Could we generate these sources in the build directory instead, and add them to the build from there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org