lordgamez commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452480781
########## extensions/grafana-loki/protos/grafana-loki-push.proto: ########## Review Comment: This file defines the grpc service and the protobuf messages structures according to grafana's protocol definition in this file: https://github.com/grafana/loki/blob/main/pkg/push/push.proto Only the used fields and attributes are kept, removing the go specific attributes and imports. In the Grafana repository the containing directory holds an Apache license (https://github.com/grafana/loki/blob/main/pkg/push/LICENSE) so I think we should be okay with the license header, I can add a reference comment to the original proto file it that's okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
