szaszm commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1505905580
########## cmake/MiNiFiOptions.cmake: ########## Review Comment: What happens if all of these remain off? I'd switch to no redistributables by default, unless the user asks for merge modules or redist DLLs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org