szaszm commented on code in PR #1734:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1509232446
##########
cmake/MiNiFiOptions.cmake:
##########
@@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF)
set_property(CACHE STRICT_GSL_CHECKS PROPERTY STRINGS
${STRICT_GSL_CHECKS_Values})
if (WIN32)
+ add_minifi_option(INSTALLER_MERGE_MODULES "Creates installer with merge
modules" OFF)
+ add_minifi_option(INSTALLER_WITH_VC_REDISTRIBUTABLES "Creates installer
with Visual C++ redistributables included" OFF)
Review Comment:
The naming is confusing, and not specific enough. Merge modules and bundled
DLLs are both Visual C++ redistributable runtimes (runtime meaning library or
DLL in this case), they're just different ways of installing the same DLLs of
the C and C++ standard libraries. Under the old version, if the user didn't ask
for merge modules, they got bundled DLLs.
There is also the Universal C Runtime (UCRT) DLLs that are not part of the
same Visual C++ redistributable runtimes package, but they are also standard
library DLLs, they also fall under the same license terms, and are not
redistributable under the Apache License. If someone wants to NOT include the
Visual C++ redistributable runtime, then they probably want a package free of
Microsoft blobs, and they don't want to include the UCRT either.
The previous version was fine, as it treated both kinds of redistributables
under the same banner, disabling them altogether. This new version seems to
treat the Visual C++ redistributable runtime package separately from the UCRT,
and I don't see the rationale behind this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
