fgerlits commented on code in PR #1725: URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1513225896
########## libminifi/include/core/ProcessGroup.h: ########## @@ -205,6 +205,8 @@ class ProcessGroup : public CoreComponent { */ std::shared_ptr<core::controller::ControllerServiceNode> findControllerService(const std::string &nodeId) const; + std::vector<std::shared_ptr<core::controller::ControllerServiceNode>> getAllControllerServices() const; Review Comment: I have changed this in 929aafecc10ae3d41ce8623d062de58c4f785abe Now the interface is a bit of a mess, with a mix of return types; I have created a Jira to fix this: https://issues.apache.org/jira/browse/MINIFICPP-2312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org